Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Color Adjustments #219

Closed
wants to merge 1 commit into from

Conversation

simonbethke
Copy link
Contributor

@simonbethke simonbethke commented Oct 17, 2024

This is a simple approach to adjust colors of splats.
image

The current UI is as simple as it gets and as long as I have no feedback for the way the adjustments are handled at the moment I would not start implementing the saving of that.

@simonbethke simonbethke marked this pull request as draft October 17, 2024 17:29
@mvaligursky
Copy link

mvaligursky commented Oct 21, 2024

Typically, a temperature is a setting useful for photography. For postprocessing is often more useful to just hava tint color, giving users more options. Something to consider. And I mean tint as an RGB color tint, not green-magenta tint typically used for photography.

@simonbethke
Copy link
Contributor Author

I totally agree, that temperature is useful for photogaphy. Thats why I integrated it here. :)

@mvaligursky
Copy link

It's too limited option, typically used to color correct images. When people create splats, they have an option to color correct images ahead of time. Further color adjustments to splats are sometimes needed to fit the splat into their 3D (non photo based) environment, or apply artistic changes to it. This is not a photo color balancing any more.

@simonbethke
Copy link
Contributor Author

I am people and I implemented it as I really need it.

@slimbuck
Copy link
Member

This is awesome @simonbethke, thanks so much!

Could you make the 3 controls sliders instead of entry boxes?

I think the COLOR panel actually requires its own popup. This would be toggled by a new icon on the right toolbar (similar to VIEW OPTIONS panel).

I will actually be adding a new panel for CAMERA POSES next. I will do this in a way that should make adding the COLOR panel easy.

And I'm happy to start with the relatively simple controls, we can always extend them in future.

@simonbethke
Copy link
Contributor Author

Awesome! I like to add sliders, but I have to learn more about the availabile ui widgets

@slimbuck
Copy link
Member

slimbuck commented Nov 7, 2024

This PR was awesome to get the ball rolling, thanks again. Closing in favour of #267

@slimbuck slimbuck closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants